netdev - Re: [PATCH 1/5] tcp: heed result of security_inet_conn_request() in tcp_v6_conn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120625.160532.11456533643470796.davem@davemloft.net>
Date:	Mon, 25 Jun 2012 16:05:32 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	ncardwell@...gle.com, netdev@...r.kernel.org, edumazet@...gle.com,
	therbert@...gle.com
Subject: Re: [PATCH 1/5] tcp: heed result of security_inet_conn_request()
 in tcp_v6_conn_request()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Sun, 24 Jun 2012 09:36:57 +0200

> On Sun, 2012-06-24 at 01:22 -0400, Neal Cardwell wrote:
>> If security_inet_conn_request() returns non-zero then TCP/IPv6 should
>> drop the request, just as in TCP/IPv4 and DCCP in both IPv4 and IPv6.
>> 
>> Signed-off-by: Neal Cardwell <ncardwell@...gle.com>
>> ---
>>  net/ipv6/tcp_ipv6.c |    3 ++-
>>  1 files changed, 2 insertions(+), 1 deletions(-)
>> 
>> diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c
>> index 3a9aec2..9df64a5 100644
>> --- a/net/ipv6/tcp_ipv6.c
>> +++ b/net/ipv6/tcp_ipv6.c
>> @@ -1212,7 +1212,8 @@ have_isn:
>>  	tcp_rsk(req)->snt_isn = isn;
>>  	tcp_rsk(req)->snt_synack = tcp_time_stamp;
>>  
>> -	security_inet_conn_request(sk, skb, req);
>> +	if (security_inet_conn_request(sk, skb, req))
>> +		goto drop_and_release;
>>  
>>  	if (tcp_v6_send_synack(sk, req,
>>  			       (struct request_values *)&tmp_ext,
> 
> Acked-by: Eric Dumazet <edumazet@...gle.com>

Applied to 'net'.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html