netdev - RE: [PATCH] net-next: ipv6: ndisc: allocate a ndisc socket per inet6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1340625757.10893.40.camel@edumazet-glaptop>
Date:	Mon, 25 Jun 2012 14:02:37 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Menny_Hamburger@...l.com
Cc:	netdev@...r.kernel.org
Subject: RE: [PATCH] net-next: ipv6: ndisc: allocate a ndisc socket per
 inet6_dev

On Mon, 2012-06-25 at 12:08 +0100, Menny_Hamburger@...l.com wrote:
> I'm sorry for not responding on your post.

...

> I really want to understand how this fixes our problem.
> This fix will make the skb allocations succeed, but what mechanism releases the stuck socket associated with the bad device?

There is no stuck socket, I don't know why you believe this.

And I don't want to spend time writing a changelog if the patch doesn't
solve the problem, especially knowing you didn't even test it.

net/ipv4/arp.c arp_create() doesn't use a 'global socket' to attach skbs
on a socket.

This kind of protection makes sense for UDP / ICMP sockets, not for ARP
or ND resolution.

If you don't understand my patch, don't post your own, thats really lost
time for everyone.

We don't want adding yet another per device stuff for ipv6.
We already have too big memory footprint.

Once I am sure patch fixes the problem, I'll make an official submission
with all credits and changelog.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html