netdev - RE: [PATCH 2/7] sock_diag: Do not use RTA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AE90C24D6B3A694183C094C60CF0A2F6026B6F66@saturn3.aculab.com>
Date:	Wed, 27 Jun 2012 11:00:30 +0100
From:	"David Laight" <David.Laight@...LAB.COM>
To:	"Thomas Graf" <tgraf@...g.ch>, <davem@...emloft.net>
Cc:	<netdev@...r.kernel.org>
Subject: RE: [PATCH 2/7] sock_diag: Do not use RTA_PUT() macros

 
> @@ -35,9 +34,7 @@ EXPORT_SYMBOL_GPL(sock_diag_save_cookie);
>  
>  int sock_diag_put_meminfo(struct sock *sk, struct sk_buff 
> *skb, int attrtype)
>  {
> -	__u32 *mem;
> -
> -	mem = RTA_DATA(__RTA_PUT(skb, attrtype, SK_MEMINFO_VARS *
sizeof(__u32)));
> +	u32 mem[SK_MEMINFO_VARS];

Isn't that likely to blow the kernel stack?

	David


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html