netdev - Re: [PATCH 1/1] connector: use nlmsg_put() instead of NLMSG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120626.211445.403519457708632249.davem@davemloft.net>
Date:	Tue, 26 Jun 2012 21:14:45 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	javier.martinez@...labora.co.uk
Cc:	zbr@...emap.net, netdev@...r.kernel.org
Subject: Re: [PATCH 1/1] connector: use nlmsg_put() instead of NLMSG_PUT()
 macro.

From: Javier Martinez Canillas <javier.martinez@...labora.co.uk>
Date: Tue, 26 Jun 2012 17:41:24 +0200

> The NLMSG_PUT() macro contains a hidden goto which makes the code hard
> to audit and very error prone.
> 
> While been there also use the inline function nlmsg_data() instead of the
> NLMSG_DATA() macro to do explicit type checking.
> 
> Signed-off-by: Javier Martinez Canillas <javier.martinez@...labora.co.uk>

Applied, thanks.

I'll work to convert the remaining users, good catch.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html