netdev - Re: [Xen-devel] [PATCH 1/1] xen/netback: only non-freed SKB is queued into tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120628.165550.1816352825092253548.davem@davemloft.net>
Date:	Thu, 28 Jun 2012 16:55:50 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	annie.li@...cle.com
Cc:	xen-devel@...ts.xensource.com, netdev@...r.kernel.org,
	Ian.Campbell@...rix.com, konrad.wilk@...cle.com,
	kurt.hackel@...cle.com
Subject: Re: [Xen-devel] [PATCH 1/1] xen/netback: only non-freed SKB is
 queued into tx_queue

From: annie.li@...cle.com
Date: Wed, 27 Jun 2012 18:46:58 +0800

> From: Annie Li <Annie.li@...cle.com>
> 
> After SKB is queued into tx_queue, it will be freed if request_gop is NULL.
> However, no dequeue action is called in this situation, it is likely that
> tx_queue constains freed SKB. This patch should fix this issue, and it is
> based on 3.5.0-rc4+.
> 
> This issue is found through code inspection, no bug is seen with it currently.
> I run netperf test for several hours, and no network regression was found.
> 
> Signed-off-by: Annie Li <annie.li@...cle.com>

I lack the expertiece necessary to properly review this, so I really
need a Xen expert to look this over.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html