netdev - Re: [patch net-next] virtio_net: allow to change mac when iface is running

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120627.213046.1244710404799995026.davem@davemloft.net>
Date:	Wed, 27 Jun 2012 21:30:46 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jpirko@...hat.com
Cc:	netdev@...r.kernel.org, rusty@...tcorp.com.au, mst@...hat.com,
	virtualization@...ts.linux-foundation.org, brouer@...hat.com
Subject: Re: [patch net-next] virtio_net: allow to change mac when iface is
 running

From: Jiri Pirko <jpirko@...hat.com>
Date: Wed, 27 Jun 2012 17:27:46 +0200

> Signed-off-by: Jiri Pirko <jpirko@...hat.com>

Applied, but this seriously makes eth_mac_addr() completely useless.

Technically, every eth_mac_addr() user in a software/virtual device
should behave the way virtio_net does now.

It therefore probably makes sense to add a boolean arg which when true
elides the netif_running() check then fixup and audit every caller.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html