netdev - Re[2]: BUG: NULL pointer in ctnetlink_conntrack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <dri38gk.7565a5f72fad1195f68b28af6833796c@obelix.schillstrom.com>
Date:	Fri, 29 Jun 2012 20:22:15 +0200 (CEST)
From:	"Hans Schillstrom" <hans@...illstrom.com>
To:	"Pablo Neira Ayuso" <pablo@...filter.org>
Cc:	netdev@...r.kernel.org, netfilter-devel@...r.kernel.org
Subject: Re[2]:  BUG: NULL pointer in ctnetlink_conntrack_event

>On Fri, Jun 29, 2012 at 02:29:37PM +0200, Hans Schillstrom wrote:
>> Hello,
>> 
>> There is a "hard to find" problem in ctnetlink_conntrack_event() when calling
>> netlink_has_listeners() net->nfnl is NULL.
>> 
>> The rcu stuff seems to be right at a first look but who knows...
>> 
>> The line below fix the problem, but that is not the root cause.
>> 
>>  int nfnetlink_has_listeners(struct net *net, unsigned int group)
>>  {
>> -       return netlink_has_listeners(net->nfnl, group);
>> +       return net->nfnl ? netlink_has_listeners(net->nfnl, group) : 0 ;
>>  }
>> 
>> Yes it is a 3.0.26 kernel but this patch is applied
>> netfilter: nf_conntrack: make event callback registration per-netns
>
>I think this patch above is missing some rcu_access_pointer usage.
>
>Please, see patch attached.

Thanks it looks like it's the missing patch.

/Hans

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html