netdev - Re: [PATCH net-next] cnic: Fix mmap regression.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120629.153425.24594752441419170.davem@davemloft.net>
Date:	Fri, 29 Jun 2012 15:34:25 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mchan@...adcom.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] cnic: Fix mmap regression.

From: "Michael Chan" <mchan@...adcom.com>
Date: Fri, 29 Jun 2012 12:32:45 -0700

> commit 1f85d58cdf15354a7120fc9ccc9bb9c45b53af88
>     cnic: Remove uio mem[0].
> 
> introduced a regression as older versions of userspace app still rely
> on this mmap.  Restore the mmap functionality and get the base address
> from pci_resource_start() as the nedev->base_addr has been deprecated for
> PCI devices.
> 
> Update version to 2.5.12.
> 
> Signed-off-by: Michael Chan <mchan@...adocm.com>

I really couldn't believe what you guys were doing in the original
commit, but I decided to let you do stupid things and find out the
hard way that removing any user visible interface is basically
impossible.

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html