netdev - Re: [PATCH net-next 2/6] qlge: Stand-up card should not report supporting wol.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120629230200.GA22193@electric-eye.fr.zoreil.com>
Date:	Sat, 30 Jun 2012 01:02:00 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Jitendra Kalsaria <jitendra.kalsaria@...gic.com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Dept-NX Linux NIC Driver 
	<Dept_NX_Linux_NIC_Driver@...gic.com>
Subject: Re: [PATCH net-next 2/6] qlge: Stand-up card should not report supporting wol.

(linux-zupk.site removed)

Jitendra Kalsaria <jitendra.kalsaria@...gic.com> :
[...]
> - broken indent
> - netif_err(... "cleared successfully" ...)
> [JK] I don't think so, %s will be replace with "cleared successfully" or with "clear failed" depend upon status value.

I would not netif_err when everything is ok.

[...]
> If I read things correctly, WAKE_MAGIC can not be cleared and it makes no
> difference on the status code. It should be fixed.
> 
> [JK] You right, here we are not clearing WAKE_MAGIC but we are making sure that wol is disable when no option is set.

Imho wol should be disabled as well when neither WAKE_MAGIC nor any option
is set at all.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html