| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 29 Jun 2012 00:50:37 -0700 (PDT) From: David Miller <davem@...emloft.net> To: Ian.Campbell@...rix.com Cc: annie.li@...cle.com, xen-devel@...ts.xensource.com, netdev@...r.kernel.org, konrad.wilk@...cle.com, kurt.hackel@...cle.com Subject: Re: [Xen-devel] [PATCH 1/1] xen/netback: only non-freed SKB is queued into tx_queue From: Ian Campbell <Ian.Campbell@...rix.com> Date: Fri, 29 Jun 2012 08:23:09 +0100 > On Fri, 2012-06-29 at 00:55 +0100, David Miller wrote: >> From: annie.li@...cle.com >> Date: Wed, 27 Jun 2012 18:46:58 +0800 >> >> > From: Annie Li <Annie.li@...cle.com> >> > >> > After SKB is queued into tx_queue, it will be freed if request_gop is NULL. >> > However, no dequeue action is called in this situation, it is likely that >> > tx_queue constains freed SKB. This patch should fix this issue, and it is >> > based on 3.5.0-rc4+. >> > >> > This issue is found through code inspection, no bug is seen with it currently. >> > I run netperf test for several hours, and no network regression was found. >> > >> > Signed-off-by: Annie Li <annie.li@...cle.com> >> >> I lack the expertiece necessary to properly review this, so I really >> need a Xen expert to look this over. > > Sorry, I put it to one side waiting for the repost to netdev and then > forgot about it... > > Yes, this change looks good to me: > > Acked-by: Ian Campbell <ian.campbell@...rix.com> Thanks, applied to net-next. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists