lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 01 Jul 2012 00:26:06 -0700 (PDT) From: David Miller <davem@...emloft.net> To: jeffrey.t.kirsher@...el.com Cc: bruce.w.allan@...el.com, netdev@...r.kernel.org, gospo@...hat.com, sassmann@...hat.com, stable@...r.kernel.org Subject: Re: [net] e1000e: remove use of IP payload checksum From: Jeff Kirsher <jeffrey.t.kirsher@...el.com> Date: Sat, 30 Jun 2012 23:02:42 -0700 > From: Bruce Allan <bruce.w.allan@...el.com> > > Currently only used when packet split mode is enabled with jumbo frames, > IP payload checksum (for fragmented UDP packets) is mutually exclusive with > receive hashing offload since the hardware uses the same space in the > receive descriptor for the hardware-provided packet checksum and the RSS > hash, respectively. Users currently must disable jumbos when receive > hashing offload is enabled, or vice versa, because of this incompatibility. > Since testing has shown that IP payload checksum does not provide any real > benefit, just remove it so that there is no longer a choice between jumbos > or receive hashing offload but not both as done in other Intel GbE drivers > (e.g. e1000, igb). > > Also, add a missing check for IP checksum error reported by the hardware; > let the stack verify the checksum when this happens. > > CC: stable <stable@...r.kernel.org> [3.4] > Signed-off-by: Bruce Allan <bruce.w.allan@...el.com> > Tested-by: Aaron Brown <aaron.f.brown@...el.com> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com> Applied, thanks Jeff. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists