lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 01 Jul 2012 03:20:21 -0700 (PDT) From: David Miller <davem@...emloft.net> To: ogerlitz@...lanox.com Cc: roland@...nel.org, yevgenyp@...lanox.com, oren@...lanox.com, netdev@...r.kernel.org, hadarh@...lanox.co.il Subject: Re: [PATCH net-next 04/10] net/mlx4: Set steering mode according to device capabilities From: Or Gerlitz <ogerlitz@...lanox.com> Date: Sun, 1 Jul 2012 12:43:37 +0300 > + /* Add the default qp number as multicast > + * promisc */ This is not the correct way to format a comment, do it: /* Like * this. */ > + if (dev->caps.flags & MLX4_DEV_CAP_FLAG_VEP_UC_STEER && > + dev->caps.flags & MLX4_DEV_CAP_FLAG_VEP_MC_STEER) { > + dev->caps.steering_mode = MLX4_STEERING_MODE_B0; > + > + } else { That empty line is extraneous and ugly, remove it. > +/* Driver supports 2 diffrent device methods to manage traffic steering: > + - B0 steering mode - Common low level API for ib and (if supported) eth. > + - A0 steering mode - Limited low level API for eth. In case of IB, > + B0 mode is in use. > + */ Improperly formatted, do it like this: /* Driver supports 2 diffrent device methods to manage traffic steering: * - B0 steering mode - Common low level API for ib and (if supported) eth. * - A0 steering mode - Limited low level API for eth. In case of IB, * B0 mode is in use. */ -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists