[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4FF09EA5.5030605@8192.net>
Date: Sun, 01 Jul 2012 12:01:57 -0700
From: John Eaglesham <linux@...2.net>
To: David Miller <davem@...emloft.net>
CC: netdev@...r.kernel.org
Subject: Re: [PATCH v5] bonding support for IPv6 transmit hashing
On 7/1/2012 3:33 AM, David Miller wrote:
> From: John Eaglesham <linux@...2.net>
> Date: Sun, 1 Jul 2012 01:07:43 -0700
>
>> + v6hash =
>> + (ipv6h->saddr.s6_addr32[1] ^ ipv6h->daddr.s6_addr32[1]) ^
>> + (ipv6h->saddr.s6_addr32[2] ^ ipv6h->daddr.s6_addr32[2]) ^
>> + (ipv6h->saddr.s6_addr32[3] ^ ipv6h->daddr.s6_addr32[3]);
>
> You completely ignored my feedback:
>
> This is rediculous, just put &ipv6h->saddr into a local
> pointer named 's' and then you won't have use such gymnastics
> to indent the code.
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
My apologies, I completely misunderstood your feedback. I will make the
correction and re-submit.
Thanks.
John
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists