netdev - Re: [PATCH net-next 1/2] ipv6: remove unnecessary codes in tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1341219281.5269.36.camel@edumazet-glaptop>
Date:	Mon, 02 Jul 2012 10:54:41 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	roy.qing.li@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/2] ipv6: remove unnecessary codes in
 tcp_ipv6.c

On Mon, 2012-07-02 at 10:13 +0200, Eric Dumazet wrote:

> Note that the old one is the np->opt of the listener, not the child.
> 
> I dont understand how np->opt could change under us, since we have
> the listener socket locked.
> 
> If np->opt can change under us, we are doomed and need to add refcounts.

Hmm, it seems net/ipv6/udp.c uses np->opt outside of the
lock_sock()/release_sock(sk) boundary.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html