netdev - Re: [PATCH net-next 09/10] net/mlx4_en: Manage flow steering rules with ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m28vf2o0oa.fsf@igel.home>
Date:	Mon, 02 Jul 2012 13:35:49 +0200
From:	Andreas Schwab <schwab@...ux-m68k.org>
To:	"David Laight" <David.Laight@...LAB.COM>
Cc:	"Joe Perches" <joe@...ches.com>,
	"Ben Hutchings" <bhutchings@...arflare.com>,
	"Or Gerlitz" <ogerlitz@...lanox.com>, <davem@...emloft.net>,
	<roland@...nel.org>, <yevgenyp@...lanox.com>, <oren@...lanox.com>,
	<netdev@...r.kernel.org>, "Hadar Hen Zion" <hadarh@...lanox.co.il>
Subject: Re: [PATCH net-next 09/10] net/mlx4_en: Manage flow steering rules with ethtool

"David Laight" <David.Laight@...LAB.COM> writes:

>  
>> > Or write it as (!field || !(typeof(field))~field) which more closely
>> > resembles what the macro name expresses.
>> 
>> Better still, or maybe:
>> 
>> 	field == 0 || field == (typeof field)~0
>
> Which doesn't work when sizeof(field) > sizeof(int).
> Needs another cast.
>
> 	field == 0 || field == (typeof field)~(typeof field)0

You can avoid that by using (typeof field)-1.

Andreas.

-- 
Andreas Schwab, schwab@...ux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html