netdev - Re: [PATCH 12/19] neigh: Convert over to dst_neigh_lookup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120703.161838.1454152280922745017.davem@davemloft.net>
Date:	Tue, 03 Jul 2012 16:18:38 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 12/19] neigh: Convert over to dst_neigh_lookup_skb().

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Tue, 3 Jul 2012 23:08:29 +0100

> On Tue, 2012-07-03 at 02:46 -0700, David Miller wrote:
>> Signed-off-by: David S. Miller <davem@...emloft.net>
>> ---
>>  net/core/neighbour.c |   10 ++++++++--
>>  1 file changed, 8 insertions(+), 2 deletions(-)
>> 
>> diff --git a/net/core/neighbour.c b/net/core/neighbour.c
>> index a793af9..eb3efdc 100644
>> --- a/net/core/neighbour.c
>> +++ b/net/core/neighbour.c
>> @@ -1202,9 +1202,15 @@ int neigh_update(struct neighbour *neigh, const u8 *lladdr, u8 new,
>>  
>>  			rcu_read_lock();
>>  			/* On shaper/eql skb->dst->neighbour != neigh :( */
> 
> It might be time to delete that comment too.

It's still accurate, so it needs to be adjusted rather then removed.
sch_teql creates this situation as well.

What this code is effectively doing is reinjecting the packet back to
the top-most neigh, and it will filter back down to the thing that
uses a different neigh for packet output.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html