[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20120702.224351.1587084404665143719.davem@davemloft.net>
Date: Mon, 02 Jul 2012 22:43:51 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: linux@...2.net
Cc: fubar@...ibm.com, netdev@...r.kernel.org
Subject: Re: [PATCH v6] bonding support for IPv6 transmit hashing
From: John Eaglesham <linux@...2.net>
Date: Mon, 02 Jul 2012 22:38:05 -0700
> On 7/2/2012 10:14 PM, David Miller wrote:
>> From: John Eaglesham <linux@...2.net>
>> Date: Mon, 02 Jul 2012 22:01:20 -0700
>>
>>> I replaced the mixed tabs and spaces with all tabs when I updated that
>>> function, but in retrospect the tabs and spaces were likely
>>> intentional. I will revert.
>>
>> They were. Don't change existing coding style unless you are certain
>> it is wrong.
>>
>> Besides any such changes are completely outside of the scope of
>> the changes you are making, so you should have left them out in
>> any event.
>> --
>> To unsubscribe from this list: send the line "unsubscribe netdev" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
> Should the indents in the code I am adding follow the style guide and
> use only tabs, or follow the style already present and mix spaces and
> tabs for indentation?
You should use a mix of tabs, as necessary, to get things to line up
how I told you they need to line up.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists