netdev - Re: [PATCH 16/19] ipv6: Store route neighbour in rt6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120705131413.GD1869@secunet.com>
Date:	Thu, 5 Jul 2012 15:14:13 +0200
From:	Steffen Klassert <steffen.klassert@...unet.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 16/19] ipv6: Store route neighbour in rt6_info struct.

On Tue, Jul 03, 2012 at 02:47:00AM -0700, David Miller wrote:
> 
> This makes for a simplified conversion away from dst_get_neighbour*().
> 
> All code outside of ipv6 will use neigh lookups via dst_neigh_lookup*().
> 
> Signed-off-by: David S. Miller <davem@...emloft.net>
> ---
>  include/net/ip6_fib.h   |    2 ++
>  net/ipv6/ip6_output.c   |    8 ++++++--
>  net/ipv6/route.c        |   42 ++++++++++++++++++++++++++----------------
>  net/ipv6/xfrm6_policy.c |    1 +
>  4 files changed, 35 insertions(+), 18 deletions(-)
> 
> diff --git a/include/net/ip6_fib.h b/include/net/ip6_fib.h
> index a192f78..0fedbd8 100644
> --- a/include/net/ip6_fib.h
> +++ b/include/net/ip6_fib.h
> @@ -86,6 +86,8 @@ struct fib6_table;
>  struct rt6_info {
>  	struct dst_entry		dst;
>  
> +	struct neighbour		*n;
> +

This pointer needs to be initialized when we allocate the
rt6_info, otherwise all my testboxes crash during noot.

I'll send a patch to do this.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html