netdev - Re: [PATCH 1/4] asix: Fix checkpatch warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120706.050246.2187095151022601094.davem@davemloft.net>
Date:	Fri, 06 Jul 2012 05:02:46 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	christian.riesch@...cron.at, netdev@...r.kernel.org,
	oneukum@...e.de, edumazet@...gle.com, allan@...x.com.tw,
	kernel@...savvy.com, grundler@...omium.org, tom.leiming@...il.com,
	michael@...sch.at
Subject: Re: [PATCH 1/4] asix: Fix checkpatch warnings

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 06 Jul 2012 13:58:39 +0200

> On Fri, 2012-07-06 at 13:33 +0200, Christian Riesch wrote:
>> Signed-off-by: Christian Riesch <christian.riesch@...cron.at>
>> ---
> 
>> -		netdev_err(dev->net, "Error reading PHYID register: %02x\n", ret);
>> +		netdev_err(dev->net, "Error reading PHYID register: %02x\n",
>> +			   ret);
> 
> 
> Thats ridiculous
> 
> Not all checkpatch warnings are meaningful.
> 
> I mean, they probably are for new code, but for existing one this is a
> waste of time.

Agreed.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html