netdev - Re: BUG: unable to handle kernel paging request at 00000000d8be176d

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120705.234413.823095842284954048.davem@davemloft.net>
Date:	Thu, 05 Jul 2012 23:44:13 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	wfg@...ux.intel.com, netdev@...r.kernel.org,
	steffen.klassert@...unet.com
Subject: Re: BUG: unable to handle kernel paging request at 00000000d8be176d

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Fri, 06 Jul 2012 08:41:47 +0200

> David, what do you think if I submit a patch using following accessor ?
> 
> /* get a rt6_info given a dst_entry pointer */
> static inline struct rt6_info *dst_rt6_info(struct dst_entry *dst)
> {
> 	return (struct rt6_info *)dst;
> }

I'd rather we simply not use address-of pointers in our interfaces
like we do now in some spots.

99 times out of 100 it's a case where PTR_ERR() would do.

I spent a lot of time moving both ipv4 and ipv6 in this direction,
we're almost there, and should simply finish off the remaining
cases.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html