netdev - Re: [PATCH net-next] ipv6: Initialize the neighbour pointer of rt6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120706065426.GF1869@secunet.com>
Date:	Fri, 6 Jul 2012 08:54:26 +0200
From:	Steffen Klassert <steffen.klassert@...unet.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] ipv6: Initialize the neighbour pointer of
 rt6_info on allocation

On Thu, Jul 05, 2012 at 05:16:44PM +0200, Eric Dumazet wrote:
> On Thu, 2012-07-05 at 15:18 +0200, Steffen Klassert wrote:
> >  
> >  	if (rt) {
> > -		memset(&rt->rt6i_table, 0,
> > +		memset(&rt->n, 0,
> >  		       sizeof(*rt) - sizeof(struct dst_entry));
> >  		rt6_init_peer(rt, table ? &table->tb6_peers : net->ipv6.peers);
> >  	}
> 
> Hmm, could we find a way to avoid this for future changes ?
> 
> We know dst_entry is the first field, so maybe :
> 
> if (rt) {
> 	struct dst_entry *dst = (struct dst_entry *)rt;
> 
> 	memset(dst + 1, 0, sizeof(*rt) - sizeof(*dst));
> 

Yes, I think we need to do something like this.

I've just noticed that ip6_blackhole_route, xfrm_alloc_dst,
dn_route_output_slow and dn_route_input_slow have the same issue.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html