netdev - Re: [PATCH net-next 3/5] net: Fix non-kernel-doc comments with kernel-doc start marker

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120707070442.GB27557@ritirata.org>
Date:	Sat, 7 Jul 2012 09:04:42 +0200
From:	Antonio Quartulli <ordex@...istici.org>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 3/5] net: Fix non-kernel-doc comments with
 kernel-doc start marker

On Fri, Jul 06, 2012 at 11:45:42PM +0100, Ben Hutchings wrote:
> Signed-off-by: Ben Hutchings <bhutchings@...arflare.com>
> ---
>  net/ceph/pagelist.c |    6 +++---
>  net/dcb/dcbnl.c     |    2 +-
>  net/ipv4/tcp.c      |    2 +-
>  net/tipc/socket.c   |    2 +-
>  4 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/net/ceph/pagelist.c b/net/ceph/pagelist.c
> index 13cb409..693852f 100644
> --- a/net/ceph/pagelist.c
> +++ b/net/ceph/pagelist.c
> @@ -95,7 +95,7 @@ int ceph_pagelist_reserve(struct ceph_pagelist *pl, size_t space)
>  }
>  EXPORT_SYMBOL(ceph_pagelist_reserve);
>  
> -/**
> +/*
>   * Free any pages that have been preallocated.
>   */


Am I wrong or this kind of comment should be:

/* Free any pages that have been preallocated. */


> -/**
> +/*
>   * Truncate a pagelist to the given point. Move extra pages to reserve.
>   * This won't sleep.
>   * Returns: 0 on success,

And this also should start like:

/* Truncate a pagelist to the given point. Move extra pages to reserve.
 * .....

?

Cheers,

-- 
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara

Content of type "application/pgp-signature" skipped