[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20120707.172539.1943659609718696447.davem@davemloft.net>
Date: Sat, 07 Jul 2012 17:25:39 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: bhutchings@...arflare.com
Cc: emilgoode@...il.com, edumazet@...gle.com, mirq-linux@...e.qmqm.pl,
jpirko@...hat.com, therbert@...gle.com, netdev@...r.kernel.org,
kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] net: fix non-ANSI function declaration warning
From: Ben Hutchings <bhutchings@...arflare.com>
Date: Sun, 8 Jul 2012 01:16:03 +0100
> On Sat, 2012-07-07 at 16:12 -0700, David Miller wrote:
>> From: Ben Hutchings <bhutchings@...arflare.com>
>> Date: Sat, 7 Jul 2012 20:57:29 +0100
>>
>> > On Sat, 2012-07-07 at 20:47 +0200, Emil Goode wrote:
>> >> Sparse is warning about non-ANSI function declaration.
>> >> Add void to the parameterless function.
>> >>
>> >> net/core/dev.c:1804:38: warning:
>> >> non-ANSI function declaration of function
>> >> 'netif_get_num_default_rss_queues'
>> >
>> > I also posted a patch for this (and another instance I found).
>>
>> But you were asked to fix up the comment formatting in on of those
>> patches so you need to fix that up and resubmit the entire set.
>
> You have got to be kidding. I fixed one thing, so I have to fix
> another?
You're fixing up a comment, fix it fully.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists