netdev - Re: [PATCH] gianfar: fix potential sk_wmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 09 Jul 2012 15:28:27 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, manfred.rudigier@...cron.at,
	claudiu.manoil@...escale.com, b06378@...escale.com,
	paul.gortmaker@...driver.com, afleming@...escale.com
Subject: Re: [PATCH] gianfar: fix potential sk_wmem_alloc imbalance

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 05 Jul 2012 23:45:13 +0200

> From: Eric Dumazet <edumazet@...gle.com>
> 
> commit db83d136d7f753 (gianfar: Fix missing sock reference when
> processing TX time stamps) added a potential sk_wmem_alloc imbalance
> 
> If the new skb has a different truesize than old one, we can get a
> negative sk_wmem_alloc once new skb is orphaned at TX completion.
> 
> Now we no longer early orphan skbs in dev_hard_start_xmit(), this
> probably can lead to fatal bugs.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Manfred Rudigier <manfred.rudigier@...cron.at>
> Cc: Claudiu Manoil <claudiu.manoil@...escale.com>
> Cc: Jiajun Wu <b06378@...escale.com>
> Cc: Paul Gortmaker <paul.gortmaker@...driver.com>
> Cc: Andy Fleming <afleming@...escale.com>

Now that this has been tested by Paul, I've applied it.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html