netdev - Re: [PATCH 1/2] be2net: Fix Endian

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120709.001454.1100101457356299928.davem@davemloft.net>
Date:	Mon, 09 Jul 2012 00:14:54 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	roy.qing.li@...il.com
Cc:	netdev@...r.kernel.org, somnath.kotur@...lex.com
Subject: Re: [PATCH 1/2] be2net: Fix Endian

From: roy.qing.li@...il.com
Date: Thu,  5 Jul 2012 10:05:42 +0800

> From: Li RongQing <roy.qing.li@...il.com>
> 
> ETH_P_IP is host Endian, skb->protocol is big Endian, when
> compare them, we should change ETH_P_IP from host endian
> to big endian, htons, not ntohs.
> 
> CC: Somnath Kotur <somnath.kotur@...lex.com>
> Signed-off-by: Li RongQing <roy.qing.li@...il.com>

Applied to net-next since this actually doesn't cause any real
problems winc htons() and ntohs() are implemented identically
and perform the same operation.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html