lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 9 Jul 2012 11:48:39 +0200
From:	Christian Riesch <>
To:	Eric Dumazet <>
Cc:	Grant Grundler <>,,
	Oliver Neukum <>,
	Eric Dumazet <>,
	Allan Chou <>,
	Mark Lord <>,
	Ming Lei <>,
	Michael Riesch <>
Subject: Re: [PATCH 1/4] asix: Fix checkpatch warnings

Hi all,

On Sat, Jul 7, 2012 at 10:36 AM, Eric Dumazet <> wrote:
> On Fri, 2012-07-06 at 14:43 -0700, Grant Grundler wrote:
>> Christian is clearly running as suggested in
>> Documentation/SubmittingPatches. He missed the part about "You should
>> be able to justify all violations that remain in your patch." and/or
>> didn't know about "fixing existing code is a waste of time".
>> Given the extent of the changes Christian is making (factoring out
>> asix common code from model specific code), it's helpful to have clean
>> checkpatch runs. I don't believe it's a waste of time to apply this
>> patch. Is it conflicting with any other code changes that are in
>> flight now?
> It was a waste of time for me, at least (Since I was CCed for the
> patch), and just sent my personal opinion on checkpatch generated
> patches.
> Splitting a perfectly good line :
> netdev_err(dev->net, "Error reading PHYID register: %02x\n", ret);
> into
> netdev_err(dev->net, "Error reading PHYID register: %02x\n",
>            ret);
> is a clear sign of how stupid checkpatch is.
> And fact we can spend time on discussions about checkpatch is
> astonishing.
> Automatic tools should be smart and ease people tasks, not
> slowing them.

Thanks for your comments! I admit that I was just annoyed by the lots
of checkpatch warnings and therefore just brainlessly did everything
to make it stop complaining, there was not much thinking involved. I
will try to be more sensible when I put together the next version.

But first I'd like to draw your attention to the other patches in the
patchset :-) I asked a few questions in the cover letter [1] and I
would like to hear your opinion about it. Thanks a lot!

> Note that Christian patch serie in itself is good, I don't want to block
> it at all.

Thanks :-)

Regards, Christian

To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists