netdev - Re: [PATCH 06/16] tcp: Move timestamps from inetpeer to metrics cache.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF1ivSZ--OKqu-PgTf82Rho4N8tUn+HCaDuh5V4p89KusHauWQ@mail.gmail.com>
Date:	Wed, 11 Jul 2012 00:14:50 +0800
From:	Lin Ming <mlin@...pku.edu.cn>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 06/16] tcp: Move timestamps from inetpeer to metrics cache.

On Tue, Jul 10, 2012 at 11:07 PM, David Miller <davem@...emloft.net> wrote:

> +
> +/* VJ's idea. Save last timestamp seen from this destination and hold
> + * it at least for normal timewait interval to use for duplicate
> + * segment detection in subsequent connections, before they enter
> + * synchronized state.
> + */
> +bool tcp_remember_stamp(struct sock *sk)
> +{
> +       struct dst_entry *dst = __sk_dst_get(sk);
> +       bool ret = false;
> +
> +       if (dst) {
> +               struct tcp_metrics_block *tm;
> +
> +               rcu_read_lock();
> +               tm = tcp_get_metrics(sk, dst, true);
> +               if (tm) {
> +                       struct tcp_sock *tp = tcp_sk(sk);
> +
> +                       if ((s32)(tm->tcpm_ts - tp->rx_opt.ts_recent) <= 0 ||
> +                           ((u32)get_seconds() - tm->tcpm_ts_stamp > TCP_PAWS_MSL &&
> +                            tm->tcpm_ts_stamp <= (u32)tp->rx_opt.ts_recent_stamp)) {
> +                               tm->tcpm_ts_stamp = (u32)tp->rx_opt.ts_recent_stamp;
> +                               tm->tcpm_ts = tp->rx_opt.ts_recent;
> +                       }
> +                       ret = true;
> +               }
> +               rcu_read_unlock();
> +       }

A trivial thing when "git am" this patch.

ERROR: trailing whitespace
#315: FILE: net/ipv4/tcp_metrics.c:595:
+^I}^I^I$

Regards,
Lin Ming

> +       return ret;
> +}
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html