lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <4FFCD95A.1060204@cn.fujitsu.com> Date: Wed, 11 Jul 2012 09:39:38 +0800 From: Gao feng <gaofeng@...fujitsu.com> To: Eric Dumazet <eric.dumazet@...il.com> CC: nhorman@...driver.com, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, lizefan@...wei.com, tj@...nel.org, Eric Dumazet <edumazet@...gle.com> Subject: Re: [PATCH v2] net: cgroup: fix access the unallocated memory in netprio cgroup 于 2012年07月10日 19:08, Eric Dumazet 写道: > On Tue, 2012-07-10 at 13:05 +0200, Eric Dumazet wrote: >> On Tue, 2012-07-10 at 18:44 +0800, Gao feng wrote: >>> there are some out of bound accesses in netprio cgroup. >> >>> - update_netdev_tables(); >>> + ret = extend_netdev_table(dev, max_len); >>> + if (ret < 0) >>> + goto out_free_devname; >>> + >>> ret = 0; >>> rcu_read_lock(); >>> map = rcu_dereference(dev->priomap); >> >> Its unfortunately adding a bug. >> >> extend_netdev_table() is protected by RTNL. > > Please test your next patch using : > > CONFIG_LOCKDEP=y > CONFIG_PROVE_RCU=y > > Because rtnl_dereference() should shout if you dont hold RTNL > Oops, I miss it. Thanks Eric & Neil,I will test v3 patch with these two CONFIG. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists