netdev - Re: [PATCH 03/16] tcp: Maintain dynamic metrics in local cache.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120710.205914.1537069998261422164.davem@davemloft.net>
Date:	Tue, 10 Jul 2012 20:59:14 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	joe@...ches.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 03/16] tcp: Maintain dynamic metrics in local cache.

From: Joe Perches <joe@...ches.com>
Date: Tue, 10 Jul 2012 10:02:04 -0700

> On Tue, 2012-07-10 at 08:07 -0700, David Miller wrote:
>> +	return (tm ? tm : (depth > TCP_METRICS_RECLAIM_DEPTH ?
>> +			   TCP_METRICS_RECLAIM_PTR :
>> +			   NULL));
> 
> Using multiple ?: in a single return can be a bit hard to read.

Ok I made a special function to implement this encoding.

>> +	case AF_INET:
>> +		hash = addr.addr.a4 = inet_rsk(req)->rmt_addr;
> 
> Is this a sparse error?  __be32 to unsigned int?
> Maybe it needs a __force?

Yep, the ipv6 hash calculation needs the same __force'ing.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html