netdev - Re: [PATCH] vxge/s2io: remove dead URLs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120710.232145.512531453311572431.davem@davemloft.net>
Date:	Tue, 10 Jul 2012 23:21:45 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jdmason@...zu.us
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] vxge/s2io: remove dead URLs

From: David Miller <davem@...emloft.net>
Date: Tue, 10 Jul 2012 23:18:32 -0700 (PDT)

> From: Jon Mason <jdmason@...zu.us>
> Date: Mon,  9 Jul 2012 17:07:57 -0700
> 
>> URLs to neterion.com and s2io.com no longer resolve.  Remove all references to
>> these URLs in the driver source and documentation.
>> 
>> Signed-off-by: Jon Mason <jdmason@...zu.us>
> 
> Applied, but I had to fix:
> 
>> -7. Support 
>> +6. Support 
>              ^^
> 
> that trailing whitespace.

Wow you didn't even build test this patch, otherwise you would have
seen:

drivers/net/ethernet/neterion/vxge/vxge-main.c: In function ‘vxge_probe_fw_update’:
drivers/net/ethernet/neterion/vxge/vxge-main.c:4263:3: warning: format ‘%s’ expects argument of type ‘char *’, but argument 2 has type ‘u32’ [-Wformat]
drivers/net/ethernet/neterion/vxge/vxge-main.c:4263:3: warning: format ‘%d’ expects a matching ‘int’ argument [-Wformat]

I'm fixing this up, but next time this will put you on my shit
list for sure.