netdev - Re: [PATCH] IPoIB: fix skb truesize underestimatiom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120710.233743.282062793119280863.davem@davemloft.net>
Date:	Tue, 10 Jul 2012 23:37:43 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	ogerlitz@...lanox.com, erezsh@...lanox.com, roland@...estorage.com,
	netdev@...r.kernel.org, shlomop@...lanox.com
Subject: Re: [PATCH] IPoIB: fix skb truesize underestimatiom

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 10 Jul 2012 22:03:41 +0200

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Or Gerlitz reported triggering of WARN_ON_ONCE(delta < len); in
> skb_try_coalesce()
> This warning tracks drivers that incorrectly set skb->truesize
> 
> IPoIB indeed allocates a full page to store a fragment, but only
> accounts in skb->truesize the used part of the page (frame length)
> 
> This patch fixes skb truesize underestimation, and
> also fixes a performance issue, because RX skbs have not enough tailroom
> to allow IP and TCP stacks to pull their header in skb linear part
> without an expensive call to pskb_expand_head()
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Or Gerlitz <ogerlitz@...lanox.com>

Applied to net, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html