netdev - Re: [trivial PATCH 2/7] ixgbe: remove unused #define

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1342123110.1783.83.camel@jtkirshe-mobl>
Date:	Thu, 12 Jul 2012 12:58:30 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Jon Mason <jdmason@...zu.us>
Cc:	trivial@...nel.org, linux-kernel@...r.kernel.org,
	Jesse Brandeburg <jesse.brandeburg@...el.com>,
	Bruce Allan <bruce.w.allan@...el.com>,
	Carolyn Wyborny <carolyn.wyborny@...el.com>,
	Don Skidmore <donald.c.skidmore@...el.com>,
	Greg Rose <gregory.v.rose@...el.com>,
	Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>,
	Alex Duyck <alexander.h.duyck@...el.com>,
	John Ronciak <john.ronciak@...el.com>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [trivial PATCH 2/7] ixgbe: remove unused #define

On Thu, 2012-07-12 at 12:49 -0700, Jon Mason wrote:
> On Thu, Jul 12, 2012 at 11:15 AM, Jeff Kirsher
> <jeffrey.t.kirsher@...el.com> wrote:
> > On Tue, 2012-07-10 at 15:43 -0700, Jeff Kirsher wrote:
> >> On Tue, 2012-07-10 at 15:31 -0700, Jon Mason wrote:
> >> > Remove unused IXGBE_INTEL_VENDOR_ID #define
> >> >
> >> > Signed-off-by: Jon Mason <jdmason@...zu.us>
> >> > Cc: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> >> > Cc: Jesse Brandeburg <jesse.brandeburg@...el.com>
> >> > Cc: Bruce Allan <bruce.w.allan@...el.com>
> >> > Cc: Carolyn Wyborny <carolyn.wyborny@...el.com>
> >> > Cc: Don Skidmore <donald.c.skidmore@...el.com>
> >> > Cc: Greg Rose <gregory.v.rose@...el.com>
> >> > Cc: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>
> >> > Cc: Alex Duyck <alexander.h.duyck@...el.com>
> >> > Cc: John Ronciak <john.ronciak@...el.com>
> >> > ---
> >> >  drivers/net/ethernet/intel/ixgbe/ixgbe_type.h |    3 ---
> >> >  1 file changed, 3 deletions(-)
> >>
> >> This should also go through David Miller's networking tree's.
> Adding
> >> netdev mailing list.
> >>
> >> Acked-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> >
> > After looking at this further, I rescind my ACK.
> >
> > NAK, this define is used in several places in ixgbe_main.c and the
> > driver will not compile with this patch.
> 
> My apologies, I was a bit sloppy and simply rebased my old patches
> without retesting them.  The code has changed since I originally
> pushed the patch (http://www.spinics.net/lists/netdev/msg171523.html).
>  I will fix and resubmit.
> 
> Thanks,
> Jon 

Also note, that when you fix up the patch and resend it, could you
resend patch 1 (ixgb) as well to netdev@...r.kernel.org.  That way
netdev patchwork will pickup the patches and I can get them into my
queue.

Thanks!
Jeff



Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)