lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAPoiz9y2D15o4ueTCWPQHiNHexBVXSABO_1ghpKtYCruSDV-Ew@mail.gmail.com> Date: Thu, 12 Jul 2012 14:19:16 -0700 From: Jon Mason <jdmason@...zu.us> To: "David S. Miller" <davem@...emloft.net> Cc: netdev@...r.kernel.org, Christian Benvenuti <benve@...co.com>, Neel Patel <neepatel@...co.com>, Nishank Trivedi <nistrive@...co.com> Subject: Re: [PATCH 02/11] enic: remove unnecessary setting of skb->dev On Mon, Jul 9, 2012 at 5:09 PM, Jon Mason <jdmason@...zu.us> wrote: > skb->dev is being unnecessarily set after calling eth_type_trans. > eth_type_trans already sets skb->dev to the proper value, thus making this > unnecessary. > > Signed-off-by: Jon Mason <jdmason@...zu.us> > Cc: Christian Benvenuti <benve@...co.com> > Cc: Roopa Prabhu <roprabhu@...co.com> This address bounced. Anyone know of an updated address for Roopa or should they be removed from the MAINTAINERS list? > Cc: Neel Patel <neepatel@...co.com> > Cc: Nishank Trivedi <nistrive@...co.com> > --- > drivers/net/ethernet/cisco/enic/enic_main.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c b/drivers/net/ethernet/cisco/enic/enic_main.c > index 8132c78..ad1468b 100644 > --- a/drivers/net/ethernet/cisco/enic/enic_main.c > +++ b/drivers/net/ethernet/cisco/enic/enic_main.c > @@ -1300,8 +1300,6 @@ static void enic_rq_indicate_buf(struct vnic_rq *rq, > skb->ip_summed = CHECKSUM_COMPLETE; > } > > - skb->dev = netdev; > - > if (vlan_stripped) > __vlan_hwaccel_put_tag(skb, vlan_tci); > > -- > 1.7.9.5 > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists