netdev - RE: [PATCH net-next] netxen: fix link notification order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <13A253B3F9BEFE43B93C09CF75F63CAA81A934387E@MNEXMB1.qlogic.org>
Date:	Thu, 12 Jul 2012 01:27:50 -0500
From:	Rajesh Borundia <rajesh.borundia@...gic.com>
To:	Flavio Leitner <fbl@...hat.com>, netdev <netdev@...r.kernel.org>
CC:	Sony Chacko <sony.chacko@...gic.com>
Subject: RE: [PATCH net-next] netxen: fix link notification order

> -----Original Message-----
> From: Flavio Leitner [mailto:fbl@...hat.com]
> Sent: Thursday, July 12, 2012 12:27 AM
> To: netdev
> Cc: Sony Chacko; Rajesh Borundia; Flavio Leitner
> Subject: [PATCH net-next] netxen: fix link notification order
> 
> First update the adapter variables with the current speed and
> mode before fire the notification. Otherwise, the get_settings()
> may provide old values.
> 
> Signed-off-by: Flavio Leitner <fbl@...hat.com>
> ---
>  drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c
> b/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c
> index b2c1b676..bc165f4 100644
> --- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c
> +++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c
> @@ -1437,8 +1437,6 @@ netxen_handle_linkevent(struct netxen_adapter
> *adapter, nx_fw_msg_t *msg)
>  				netdev->name, cable_len);
>  	}
> 
> -	netxen_advert_link_change(adapter, link_status);
> -
>  	/* update link parameters */
>  	if (duplex == LINKEVENT_FULL_DUPLEX)
>  		adapter->link_duplex = DUPLEX_FULL;
> @@ -1447,6 +1445,8 @@ netxen_handle_linkevent(struct netxen_adapter
> *adapter, nx_fw_msg_t *msg)
>  	adapter->module_type = module;
>  	adapter->link_autoneg = autoneg;
>  	adapter->link_speed = link_speed;
> +
> +	netxen_advert_link_change(adapter, link_status);
>  }
> 
>  static void
> --
> 1.7.10.4
> 
Acked-by: Rajesh Borundia <rajesh.borundia@...gic.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html