netdev - Re: [PATCH 05/16] ipv4: Generalize ip_do_redirect() and hook into new dst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 12 Jul 2012 02:05:25 -0700
From:	Joe Perches <joe@...ches.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 05/16] ipv4: Generalize ip_do_redirect() and hook into
 new dst_ops->redirect.

On Thu, 2012-07-12 at 01:11 -0700, David Miller wrote:
> All of the redirect acceptance policy is now contained within.
[]
> @@ -1271,42 +1273,18 @@ static void rt_del(unsigned int hash, struct rtable *rt)
>  	spin_unlock_bh(rt_hash_lock_addr(hash));
>  }
>  
> -static void ip_do_redirect(struct rtable *rt, __be32 old_gw, __be32 new_gw)
> -{
> -	struct neighbour *n;
> -
> -	if (rt->rt_gateway != old_gw)
> -		return;
> -
> -	n = ipv4_neigh_lookup(&rt->dst, NULL, &new_gw);
> -	if (n) {
> -		if (!(n->nud_state & NUD_VALID)) {
> -			neigh_event_send(n, NULL);
> -		} else {
> -			rt->rt_gateway = new_gw;
> -			rt->rt_flags |= RTCF_REDIRECTED;
> -			call_netevent_notifiers(NETEVENT_NEIGH_UPDATE, n);
> -		}
> -		neigh_release(n);
> -	}
> -}

Oh well, nevermind about the comment I made in 3/6.
I should read the whole thing first.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html