netdev - Re: [PATCH v3] tg3: add device id of Apple Thunderbolt Ethernet device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1342163982.7472.83.camel@LTIRV-MCHAN1.corp.ad.broadcom.com>
Date:	Fri, 13 Jul 2012 00:19:42 -0700
From:	"Michael Chan" <mchan@...adcom.com>
To:	"Roland Dreier" <roland@...estorage.com>
cc:	"Greg KH" <gregkh@...uxfoundation.org>,
	"Matt Carlson" <mcarlson@...adcom.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v3] tg3: add device id of Apple Thunderbolt Ethernet
 device

On Thu, 2012-07-12 at 22:33 -0700, Roland Dreier wrote: 
> On Thu, Jul 12, 2012 at 6:39 PM, Greg KH <gregkh@...uxfoundation.org> wrote:
> > The Apple Thunderbolt ethernet device is already listed in the driver,
> > but not hooked up in the MODULE_DEVICE_TABLE().  This fixes that and
> > allows it to work properly.
> >
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> >
> > ---
> > Resent to Cc: the proper developers this time.
> >
> > diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
> > index e47ff8b..3721833 100644
> > --- a/drivers/net/ethernet/broadcom/tg3.c
> > +++ b/drivers/net/ethernet/broadcom/tg3.c
> > @@ -298,6 +298,7 @@ static DEFINE_PCI_DEVICE_TABLE(tg3_pci_tbl) = {
> >         {PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_57795)},
> >         {PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_5719)},
> >         {PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_5720)},
> > +       {PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, TG3PCI_DEVICE_TIGON3_57762)},
> >         {PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_9DXX)},
> >         {PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_9MXX)},
> >         {PCI_DEVICE(PCI_VENDOR_ID_ALTIMA, PCI_DEVICE_ID_ALTIMA_AC1000)},
> 
> I realize there's no way Greg can know the answer to this or test the
> corresponding change...
> 
> But for the Broadcom guys:
> it looks like there simiarly is code in the driver for at least
> 
> TG3PCI_DEVICE_TIGON3_57766
> TG3PCI_DEVICE_TIGON3_57782
> TG3PCI_DEVICE_TIGON3_57786
> 
> without entries in the PCI device table.  Should those similarly be added?
> 

Yeah we need to add these as well, but there may be missing code to
support these chips besides the PCI ID table entries.  We will get these
chips tested and send the complete patches to support these chips.




--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html