netdev - Re: [PATCH] sctp: fix sparse warning for sctp_init_cause

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d271696b-1103-4335-a734-3cda1e260557@email.android.com>
Date:	Sat, 14 Jul 2012 14:01:25 -0400
From:	Vlad Yasevich <vyasevich@...il.com>
To:	Ioan Orghici <ioanorghici@...il.com>, sri@...ibm.com,
	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH] sctp: fix sparse warning for sctp_init_cause_fixed

Ioan Orghici <ioanorghici@...il.com> wrote:

>Fix the following sparse warning:
>	* symbol 'sctp_init_cause_fixed' was not declared. Should it be
>	  static?
>
>Signed-off-by: Ioan Orghici <ioanorghici@...il.com>

Looks good.

Acked-by: Vlad Yasevich <vyasevich@...il.com>


>---
> net/sctp/sm_make_chunk.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c
>index b6de71e..479a70e 100644
>--- a/net/sctp/sm_make_chunk.c
>+++ b/net/sctp/sm_make_chunk.c
>@@ -132,7 +132,7 @@ void  sctp_init_cause(struct sctp_chunk *chunk,
>__be16 cause_code,
>  * abort chunk.  Differs from sctp_init_cause in that it won't oops
>  * if there isn't enough space in the op error chunk
>  */
>-int sctp_init_cause_fixed(struct sctp_chunk *chunk, __be16 cause_code,
>+static int sctp_init_cause_fixed(struct sctp_chunk *chunk, __be16
>cause_code,
> 		      size_t paylen)
> {
> 	sctp_errhdr_t err;
>-- 
>1.7.6.3


-- 
Sent from my Android phone with SkitMail. Please excuse my brevity.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html