netdev - Re: [PATCH] drivers: connector: fixed coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1342302980.8377.43.camel@joe2Laptop>
Date:	Sat, 14 Jul 2012 14:56:20 -0700
From:	Joe Perches <joe@...ches.com>
To:	Valentin Ilie <valentin.ilie@...il.com>
Cc:	zbr@...emap.net, netdev@...r.kernel.org
Subject: Re: [PATCH] drivers: connector: fixed coding style issues

On Sun, 2012-07-15 at 00:51 +0300, Valentin Ilie wrote:
> On 14 July 2012 23:33, Joe Perches <joe@...ches.com> wrote:
> > I think it would be better written by hoisting the
> > function outside the if like [..]
> 
> OK.
> 
> Should I submit the whole patch again (with that change) or just
> another small patch that does just that?

It's generally better to reply to the original patch
with [PATCH V2] with the entire patch content updated.

btw: there's a missing a semicolon in what I posted.

Also add a changelog after the --- so the new patch
email looks like:

Subject: [PATCH V2] drivers: connectors: etc

Patch description...

Signed-off-by: etc
---
v2: Updated to do whatever

actual patch...

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html