lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1342441945.23494.23.camel@edumazet-glaptop> Date: Mon, 16 Jul 2012 14:32:25 +0200 From: Eric Dumazet <eric.dumazet@...il.com> To: Andrew Vagin <avagin@...nvz.org> Cc: "David S. Miller" <davem@...emloft.net>, Alexey Kuznetsov <kuznet@....inr.ac.ru>, James Morris <jmorris@...ei.org>, Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>, Patrick McHardy <kaber@...sh.net>, Pavel Emelyanov <xemul@...allels.com>, linux-kernel@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH] net-next: make sock diag per-namespace On Mon, 2012-07-16 at 16:14 +0400, Andrew Vagin wrote: > Before this patch sock_diag works for init_net only and dumps > information about sockets from all namespaces. ... > diff --git a/net/ipv4/udp_diag.c b/net/ipv4/udp_diag.c > index a7f86a3..52f42f9 100644 > --- a/net/ipv4/udp_diag.c > +++ b/net/ipv4/udp_diag.c > @@ -34,6 +34,7 @@ static int udp_dump_one(struct udp_table *tbl, struct sk_buff *in_skb, > int err = -EINVAL; > struct sock *sk; > struct sk_buff *rep; > + struct net *net = sock_net(in_skb->sk); > > if (req->sdiag_family == AF_INET) > sk = __udp4_lib_lookup(&init_net, It seems you didnt fix udp_dump_one() correctly, since it still mentions &init_net > @@ -75,7 +76,7 @@ static int udp_dump_one(struct udp_table *tbl, struct sk_buff *in_skb, > kfree_skb(rep); > goto out; > } > - err = netlink_unicast(sock_diag_nlsk, rep, NETLINK_CB(in_skb).pid, > + err = netlink_unicast(net->diag_nlsk, rep, NETLINK_CB(in_skb).pid, > MSG_DONTWAIT); > if (err > 0) > err = 0; udp_dump() also needs some care ? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists