netdev - Re: [PATCH] mlx4_en: map entire pages to increase throughput

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120717.064633.1533728304261811367.davem@davemloft.net>
Date:	Tue, 17 Jul 2012 06:46:33 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	David.Laight@...LAB.COM
Cc:	rick.jones2@...com, cascardo@...ux.vnet.ibm.com,
	netdev@...r.kernel.org, yevgenyp@...lanox.co.il,
	ogerlitz@...lanox.com, amirv@...lanox.com,
	brking@...ux.vnet.ibm.com, leitao@...ux.vnet.ibm.com,
	klebers@...ux.vnet.ibm.com
Subject: Re: [PATCH] mlx4_en: map entire pages to increase throughput

From: "David Laight" <David.Laight@...LAB.COM>
Date: Tue, 17 Jul 2012 14:36:11 +0100

> The driver will already have to cope with 'too many segments'
> (I remember being passed a full sized frame made of a list
> of 1-byte message blocks...)

Baring driver hardware bug workarounds, no it does not have to cope
with that.  The code is extremely simple now.

All the driver has to do is assume that a new TX packet can never
consume more than MAX_SKB_FRAGS.

Therefore it simply stops the queue if less than MAX_SKB_FRAGS
segments remain after queueing a transmit.

Your suggestion will significantly complicate driver TX paths.

If you're going to suggest a solution, it has to be completely
general enough to work in the current state of affairs, and
your idea absolutely does not.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html