| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1342565201.1898.6.camel@joe2Laptop> Date: Tue, 17 Jul 2012 15:46:41 -0700 From: Joe Perches <joe@...ches.com> To: Francois Romieu <romieu@...zoreil.com> Cc: netdev@...r.kernel.org, David Miller <davem@...emloft.net>, Hayes Wang <hayeswang@...ltek.com> Subject: Re: [PATCH net-next 0/2] Pull request for 'davem-next.r8169' branch On Wed, 2012-07-18 at 00:09 +0200, Francois Romieu wrote: > diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c Hello Francois, just a bit of trivia: > @@ -865,7 +865,8 @@ static bool rtl_loop_wait(struct rtl8169_private *tp, const struct rtl_cond *c, > if (c->check(tp) == high) > return true; > } > - netif_err(tp, drv, tp->dev, c->msg); > + netif_err(tp, drv, tp->dev, "%s == %d (loop: %d, delay: %d).\n", > + c->msg, !high, n, d); Please avoid adding the period to a message before a newline. $ git grep -E "[^\.]\\\\n\"" drivers/net/ethernet/realtek | wc -l 113 $ git grep -E "\.\\\\n\"" drivers/net/ethernet/realtek | wc -l 12 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists