netdev - Re: [PATCH net-next V1 5/9] net/eipoib: Add ethtool file support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1342636621.2617.63.camel@bwh-desktop.uk.solarflarecom.com>
Date:	Wed, 18 Jul 2012 19:37:01 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Or Gerlitz <ogerlitz@...lanox.com>
CC:	<davem@...emloft.net>, <roland@...nel.org>,
	<netdev@...r.kernel.org>, <ali@...lanox.com>,
	<sean.hefty@...el.com>, <shlomop@...lanox.com>,
	Erez Shitrit <erezsh@...lanox.co.il>
Subject: Re: [PATCH net-next V1 5/9] net/eipoib: Add ethtool file support

On Wed, 2012-07-18 at 13:59 +0300, Or Gerlitz wrote:
> From: Erez Shitrit <erezsh@...lanox.co.il>
> 
> Via ethtool the driver describes its version, ABI version, on what PIF
> interface it runs and various statistics.
[...]
> +static const char parent_strings[][ETH_GSTRING_LEN] = {
> +	/* private statistics */
> +	"tx_parent_dropped",
> +	"tx_vif_miss",
> +	"tx_neigh_miss",
> +	"tx_vlan",
> +	"tx_shared",
> +	"tx_proto_errors",
> +	"tx_skb_errors",
> +	"tx_slave_err",
> +
> +	"rx_parent_dropped",
> +	"rx_vif_miss",
> +	"rx_neigh_miss",
> +	"rx_vlan",
> +	"rx_shared",
> +	"rx_proto_errors",
> +	"rx_skb_errors",
> +	"rx_slave_err",
> +#define PORT_STATS_LEN	(8 * 2)
> +};
> +
> +#define PARENT_STATS_LEN (sizeof(parent_strings) / ETH_GSTRING_LEN)
> +
> +static void parent_get_strings(struct net_device *parent_dev,
> +			       uint32_t stringset, uint8_t *data)
> +{
> +	int index = 0, stats_off = 0, i;
> +
> +	if (stringset != ETH_SS_STATS)
> +		return;
> +
> +	for (i = 0; i < PORT_STATS_LEN; i++)
> +		strcpy(data + (index++) * ETH_GSTRING_LEN,
> +		       parent_strings[i + stats_off]);
> +
> +	stats_off += PORT_STATS_LEN;

This is a very longwinded way to write:
	memcpy(data, parent_strings, sizeof(parent_strings));

> +
> +}
> +
> +static void parent_get_ethtool_stats(struct net_device *parent_dev,
> +				     struct ethtool_stats *stats,
> +				     uint64_t *data)
> +{
> +	struct parent *parent = netdev_priv(parent_dev);
> +	int index = 0, i;
> +
> +	read_lock_bh(&parent->lock);
> +
> +	for (i = 0; i < PORT_STATS_LEN; i++)
> +		data[index++] = ((unsigned long *) &parent->port_stats)[i];
> +
> +	read_unlock_bh(&parent->lock);
> +}
> +
> +static int parent_get_sset_count(struct net_device *parent_dev, int sset)
> +{
> +	switch (sset) {
> +	case ETH_SS_STATS:
> +		return PARENT_STATS_LEN;
> +	default:
> +		return -EOPNOTSUPP;
> +	}
> +}
[...]

I get the feeling you've removed some code with unifdef; the result
looks really weird, with PORT_STATS_LEN and PARENT_STATS_LEN used
inconsistently.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html