netdev - Re: [PATCH 10/16] ipv4: Cache output routes in fib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1342736362.2626.5443.camel@edumazet-glaptop>
Date:	Fri, 20 Jul 2012 00:19:22 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 10/16] ipv4: Cache output routes in fib_info nexthops.

On Thu, 2012-07-19 at 15:13 -0700, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@...il.com>
> Date: Fri, 20 Jul 2012 00:09:03 +0200
> 
> > If we find orig not null, what can protect another cpu from reading
> > nh->nh_rth_output, then we dst_release(orig), and other cpu  does the
> > dst_use() too late ?
> 
> Indeed, we'd have to defer it somehow.
> 
> Actually, we might be able to fake this by using __dst_free() on it
> or something similar.
> 
> But safest would be RCU, whose protection we are still using on the
> read side.
> 
> Any better ideas?

Well, its very late for me in France and I really need to sleep.

I hope I really can, now that you gave me the silly idea to work on a
linux patch ;)

RCU seems a good idea at first glance.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html