lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 19 Jul 2012 19:28:25 +0300 From: Or Gerlitz <ogerlitz@...lanox.com> To: Ben Hutchings <bhutchings@...arflare.com> CC: <davem@...emloft.net>, <roland@...nel.org>, <netdev@...r.kernel.org>, <oren@...lanox.com>, <yevgenyp@...lanox.com>, Amir Vadai <amirv@...lanox.com> Subject: Re: [PATCH net-next V1 4/4] net/mlx4_en: Add accelerated RFS support On 7/19/2012 5:09 PM, Ben Hutchings wrote: >> @@ -77,6 +77,12 @@ int mlx4_en_activate_cq(struct mlx4_en_priv *priv, struct mlx4_en_cq *cq, >> > struct mlx4_en_dev *mdev = priv->mdev; >> > int err = 0; >> > char name[25]; >> >+ struct cpu_rmap *rmap = >> >+#ifdef CONFIG_RFS_ACCEL >> >+ priv->dev->rx_cpu_rmap; >> >+#else >> >+ NULL; >> >+#endif > You can write this slightly more cleanly using IS_ENABLED(). > > [...] >> >+static struct mlx4_en_filter * >> >+mlx4_en_filter_alloc(struct mlx4_en_priv *priv, int rxq_index, __be32 src_ip, >> >+ __be32 dst_ip, __be16 src_port, __be16 dst_port, >> >+ u32 flow_id) >> >+{ > [...] >> >+ filter->id = priv->last_filter_id++; > [...] > > You need to limit the filter IDs to be < RPS_NO_FILTER. OK, thanks, we will send fixes for these two comments. Or. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists