netdev - Re: [PATCH v2 net-next] tcp: fix ABC in tcp_slow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120720.110152.1959842625155766788.davem@davemloft.net>
Date:	Fri, 20 Jul 2012 11:01:52 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ncardwell@...gle.com
Cc:	ycheng@...gle.com, eric.dumazet@...il.com, netdev@...r.kernel.org,
	therbert@...gle.com, shemminger@...tta.com, johnwheffner@...il.com,
	nanditad@...gle.com
Subject: Re: [PATCH v2 net-next] tcp: fix ABC in tcp_slow_start()

From: Neal Cardwell <ncardwell@...gle.com>
Date: Fri, 20 Jul 2012 10:58:27 -0700

> On Fri, Jul 20, 2012 at 8:07 AM, Yuchung Cheng <ycheng@...gle.com> wrote:
>> On Fri, Jul 20, 2012 at 8:02 AM, Eric Dumazet <eric.dumazet@...il.com> wrote:
>>> From: Eric Dumazet <edumazet@...gle.com>
>>>
>>> When/if sysctl_tcp_abc > 1, we expect to increase cwnd by 2 if the
>>> received ACK acknowledges more than 2*MSS bytes, in tcp_slow_start()
>>>
>>> Problem is this RFC 3465 statement is not correctly coded, as
>>> the while () loop increases snd_cwnd one by one.
>>>
>>> Add a new variable to avoid this off-by one error.
>>>
>>> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
>> Acked-by: Yuchung Cheng <ycheng@...gle.com>
> 
> Acked-by: Neal Cardwell <ncardwell@...gle.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html