netdev - Re: [PATCH 14/16] ipv4: Kill rt->rt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120720.133115.1828569805175844233.davem@davemloft.net>
Date:	Fri, 20 Jul 2012 13:31:15 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ja@....bg
Cc:	netdev@...r.kernel.org, kaber@...sh.net
Subject: Re: [PATCH 14/16] ipv4: Kill rt->rt_oif

From: Julian Anastasov <ja@....bg>
Date: Fri, 20 Jul 2012 04:10:12 +0300 (EEST)

>> @@ -1795,7 +1795,6 @@ static struct mr_table *ipmr_rt_fib_lookup(struct net *net, struct sk_buff *skb)
>>  		.daddr = iph->daddr,
>>  		.saddr = iph->saddr,
>>  		.flowi4_tos = RT_TOS(iph->tos),
>> -		.flowi4_oif = rt->rt_oif,
>>  		.flowi4_iif = rt->rt_iif,
>>  		.flowi4_mark = skb->mark,
> 
> 	But it was wrong at first place to use rt_iif
> here. May be we should provide devices to "mrule" just
> like we do for "rule", with the only difference that
> oif now is possible to match outdev instead of preferred
> device, i.e. oif is always set for output routes.
> 
> 	.flowi4_oif = rt_is_output_route(rt) ?
> 			skb->dev->ifindex : 0,
> 	.flowi4_iif = rt_is_output_route(rt) ?
> 			net->loopback_dev->ifindex :
> 			skb->dev->ifindex;

Ok.

> 	Let me know if patch is needed

I'll take care of it myself today, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html