netdev - Re: [PATCH 11/16] ipv4: Cache input routes in fib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120723.125837.2165279339112720363.davem@davemloft.net>
Date:	Mon, 23 Jul 2012 12:58:37 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ja@....bg
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 11/16] ipv4: Cache input routes in fib_info nexthops.

From: Julian Anastasov <ja@....bg>
Date: Mon, 23 Jul 2012 23:00:57 +0300 (EEST)

> 	May be we can replace rt_iif with skb->dev->ifindex ?
> If we have dst, there must be skb->dev ? Only for
> output routes we should check places that rely on
> inet_iif().

Right, just as I was drinking my first coffee after reading
your previous email I was thinking about this.

The only time skb->dev->ifindex can change from rt->rt_iif is when we
demux a tunnel, but at that point we would first reinject and do
another route lookup, at which point rt->rt_iif would match again.

And this is the intended semantic of this field anyways.

I'll look into what we can do here, and I'll also try to come up
with some ideas wrt. the DIRECTSRC issue as well.

Thanks Julian.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html