netdev - Re: [PATCH] mlx4: Add support for EEH error recovery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120724.140353.1432900101600410863.davem@davemloft.net>
Date:	Tue, 24 Jul 2012 14:03:53 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	klebers@...ux.vnet.ibm.com
Cc:	netdev@...r.kernel.org, jackm@....mellanox.co.il,
	yevgenyp@...lanox.co.il, ogerlitz@...lanox.com,
	cascardo@...ux.vnet.ibm.com, brking@...ux.vnet.ibm.com
Subject: Re: [PATCH] mlx4: Add support for EEH error recovery

From: Kleber Sacilotto de Souza <klebers@...ux.vnet.ibm.com>
Date: Fri, 20 Jul 2012 16:55:43 -0300

> Currently the mlx4 drivers don't have the necessary callbacks to
> implement EEH errors detection and recovery, so the PCI layer uses the
> probe and remove callbacks to try to recover the device after an error on
> the bus. However, these callbacks have race conditions with the internal
> catastrophic error recovery functions, which will also detect the error
> and this can cause the system to crash if both EEH and catas functions
> try to reset the device.
> 
> This patch adds the necessary error recovery callbacks and makes sure
> that the internal catastrophic error functions will not try to reset the
> device in such scenarios. It also adds some calls to
> pci_channel_offline() to suppress reads/writes on the bus when the slot
> cannot accept I/O operations so we prevent unnecessary accesses to the
> bus and speed up the device removal.
> 
> Signed-off-by: Kleber Sacilotto de Souza <klebers@...ux.vnet.ibm.com>

Or, you promised an ACK today, I still haven't seen it.

There is no reason Kleber should be penalized and have his work
miss the merge window just because you guys can't be bothered
to approve this patch in a reasonable amount of time.

Therefore I'm just going to apply it later today, and don't do this
with someone's submission ever again, it impedes progress and
frustrates contributors.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html