netdev - Re: [PATCH 2/2] ipv4: Change rt->rt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <500F1E23.7090803@gmail.com>
Date:	Wed, 25 Jul 2012 00:13:55 +0200
From:	Nicolas de Pesloüan 
	<nicolas.2p.debian@...il.com>
To:	David Miller <davem@...emloft.net>
CC:	ja@....bg, netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] ipv4: Change rt->rt_iif encoding.

Le 24/07/2012 01:14, David Miller a écrit :
[...]
> I wonder if we should just get rid of all of that orig_dev logic and
> simply update skb->skb_iif every time we hit the code starting at
> label "another_round"

It clearly depends on the exact meaning of orig_dev.

When we studied the usage of orig_dev before removing it from bonding, it was clear that two 
different meanings existed:

- From the bonding point of view, is was "the device one level below current device" (the slave, 
from the master's point of view).

- From the af_packet point of view, is was "the real original device that received the packet".

As bonding don't use orig_dev anymore, the remaining meaning should logically be "the real original 
device that received the packet". But as __netif_receive_skb() is recursively called in many cases, 
setting orig_dev to something new every time, this meaning is probably mostly inconsistent. As such, 
it sounds appropriate to remove orig_dev and use skb_iif instead.

	Nicolas.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html