netdev - Re: [PATCH] decnet: Don't set RTCF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1343117644.2712.1.camel@menhir>
Date:	Tue, 24 Jul 2012 09:14:04 +0100
From:	Steven Whitehouse <swhiteho@...hat.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] decnet: Don't set RTCF_DIRECTSRC.

Hi,

On Mon, 2012-07-23 at 13:17 -0700, David Miller wrote:
> It's an ipv4 defined route flag, and only ipv4 uses it.
> 
This flag was really just being used to tag cached (direct) routes for
debugging purposes, so looks good to me.

Acked-by: Steven Whitehouse <swhiteho@...hat.com>

Steve.

> Signed-off-by: David S. Miller <davem@...emloft.net>
> ---
>  net/decnet/dn_route.c |    2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/net/decnet/dn_route.c b/net/decnet/dn_route.c
> index 23cc11d..85a3604 100644
> --- a/net/decnet/dn_route.c
> +++ b/net/decnet/dn_route.c
> @@ -1424,7 +1424,6 @@ static int dn_route_input_slow(struct sk_buff *skb)
>  		/* Packet was intra-ethernet, so we know its on-link */
>  		if (cb->rt_flags & DN_RT_F_IE) {
>  			gateway = cb->src;
> -			flags |= RTCF_DIRECTSRC;
>  			goto make_route;
>  		}
>  
> @@ -1437,7 +1436,6 @@ static int dn_route_input_slow(struct sk_buff *skb)
>  
>  		/* Close eyes and pray */
>  		gateway = cb->src;
> -		flags |= RTCF_DIRECTSRC;
>  		goto make_route;
>  	default:
>  		goto e_inval;


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html